Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test File: Disallow changing string columns to datetime #2120

Merged
merged 1 commit into from
Mar 28, 2017
Merged

Test File: Disallow changing string columns to datetime #2120

merged 1 commit into from
Mar 28, 2017

Conversation

jerneju
Copy link
Contributor

@jerneju jerneju commented Mar 20, 2017

Issue

Datetime option only if numerical. Test only.
#2050

Description of changes
Includes
  • Code changes
  • Tests
  • Documentation

@codecov-io
Copy link

codecov-io commented Mar 20, 2017 •
edited
Loading

Codecov Report

Merging #2120 into master will increase coverage by 0.04%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #2120      +/-   ##
==========================================
+ Coverage    71.5%   71.55%   +0.04%     
==========================================
  Files         318      318              
  Lines       54453    54472      +19     
==========================================
+ Hits        38939    38979      +40     
+ Misses      15514    15493      -21

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1fc9cd8...1ef8891. Read the comment docs.

@jerneju
Copy link
Contributor Author

jerneju commented Mar 21, 2017

@lanzagar

lanzagar
lanzagar requested changes Mar 21, 2017
View reviewed changes
Copy link
Contributor

@lanzagar lanzagar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like you are only creating a temp dir to create a temp file inside. Instead, you could just directly create a file with NamedTemporaryFile (and delete it later with os.remove)

@jerneju
Test File: Disallow changing string columns to datetime
1ef8891 
Datetime option only if numerical. Test only.
GH-2050
@lanzagar lanzagar merged commit 5812d5b into biolab:master Mar 28, 2017
@jerneju jerneju deleted the owfile-test-datetime-option branch April 20, 2017 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lanzagar lanzagar lanzagar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jerneju @codecov-io @lanzagar